[Fix] Created possible fix for issue #229: Remove PICS from python PWRTL tests #34094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Jun 27, 2024
j-ororke
commented
- Removed PICS if statements from python TC_PWRTL_2_1 test module
- Used read_single_attribute_check_success() to get attribute ID's for available and active endpoints then compared attribute ID's with attribute list to verify DUT's supports those attributes.
- Updated if statement checks as possible that empty lists might also be equivalent to NullValue when checking active and available endpoints on DUT's
- Removed PICS if statements from TC_PWRTL_2_1 test module - Added if statements to check if attribute ID's for available and active endpoints gathered from DUT's are contained in attribute list - Updated method from NullValue to also include checking for empty lists from DUT's for available and active endpoints
|
PR #34094: Size comparison from 2908685 to 026828d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
1 task
- Added else condition to return for cases where active or available attribute ID's were not in attibute list on DUT
|
PR #34094: Size comparison from 2908685 to 80faf03 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
cecille
reviewed
Jul 17, 2024
- Replaced method for setting endpoint variable - Removed null check for available endpoints in test step 2. - Reworded verbiage for skipping test step 3 if condition is not met.
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #34094: Size comparison from cbd15a1 to 22448f1 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Fixed found linting errors
- Resolved new found linting errors.
|
PR #34094: Size comparison from cbd15a1 to 0e73e12 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Sep 20, 2024
Co-authored-by: C Freeman <cecille@google.com>
Co-authored-by: C Freeman <cecille@google.com>
|
PR #34094: Size comparison from 83159c2 to 13cc798 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34094: Size comparison from e814987 to 22f650d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34094: Size comparison from 86a5270 to ba96dbb Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
removed
the
matter-1.4-te2-script-change
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…om python PWRTL tests (project-chip#34094) * Created possible fix for issue project-chip#229: - Removed PICS if statements from TC_PWRTL_2_1 test module - Added if statements to check if attribute ID's for available and active endpoints gathered from DUT's are contained in attribute list - Updated method from NullValue to also include checking for empty lists from DUT's for available and active endpoints * Restyled by autopep8 * Updated TC_PWRTL_2_1.py: - Added else condition to return for cases where active or available attribute ID's were not in attibute list on DUT * Restyled by autopep8 * Updated TC_PWRTL_2_1 test module: - Replaced method for setting endpoint variable - Removed null check for available endpoints in test step 2. - Reworded verbiage for skipping test step 3 if condition is not met. * Restyled by autopep8 * Updated TC_PWRTL_2_1 test module - Fixed found linting errors * Updated TC_PWRTL_2_1 test module: - Resolved new found linting errors. * Restyled by autopep8 * Apply suggestions from code review Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_PWRTL_2_1.py Co-authored-by: C Freeman <cecille@google.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: C Freeman <cecille@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.